Removing duplicated footer from iframes #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current solution, the footer gets duplicated when third-party content is loaded in an iframe, breaking the expected design. This pull request contains a script to hide the footer when the page is loaded from an iframe.
Relevant Technical Choices
The inline Javascript was a solution that could be reproduced locally, probably with multiple domains; it could be solved with Express JS checking
request.headers.referer
.Testing Instructions
feature/removing-duplicated-footer-from-iframes
branch containing these changes.npm
installed.npm install
to install all dependencies..env
file.npm start
.Screenshots
e-commerce scenario before
e-commerce scenario after