Add legacy support for ogg file format #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharmin
changed the title
thrijith
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In RFC 3534 the mime-type for ogg format was
application/ogg, but in the favor of RFC 5334 which have mime-typesvideo/oggandaudio/ogg, the RFC 3534 was obsoleted.Problem
In the current version, mime-types which have word
audioandvideoare supported, which is preventing the ogg file to transcode.Solution
In this fix, we've added the condition to check
application/oggmime-type,and handle the condition to check either it's video or audio at transcoder server side using the ffprobe tooland treating all ogg file as audio job.