Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of a=imageattr #5

Closed
ekr opened this issue May 8, 2014 · 10 comments
Closed

Handling of a=imageattr #5

ekr opened this issue May 8, 2014 · 10 comments

Comments

@ekr
Copy link
Contributor

ekr commented May 8, 2014

Section 5.2.1
o [OPEN ISSUE: Handling of a=imageattr]

@martinthomson
Copy link
Contributor

Discussed in DC: chicken chicken chicken

Harald is being assigned this particular task. He will produce text regarding the generation of and adherence to some image size preferences.

@juberti
Copy link
Contributor

juberti commented Mar 26, 2015

From #30:

IETF 92: add a=imageattr:X recv that contains the decoder limits, minimaxed with an app-specified receive limit (possibly multiple of these if there are multiple codecs with different limits).

Open question: how does the offerer set receive limits other than decoder limits? This again does suggest that RtpReceiver might need to be created at an earlier stage than ontrack.

@martinthomson
Copy link
Contributor

At the answerer, there is always the possibility of setting (mandatory) constraints on the MediaStreamTrack instances. The offerer would have to redo offer/answer to do this though. Mucking with RTCRtpReceiver is another way to achieve the same end, with the same limitation.

We should definitely pick just one option, and probably pick something in the W3C. JSEP only has to explain that there is nothing offer/answer can do to allow the answerer this control.

@juberti
Copy link
Contributor

juberti commented Mar 26, 2015

Well, I wonder if we should generate the RtpReceiver when the offerer's track is added. We wouldn't fire ontrack in that case, but you could get the receiver and frob it before calling createoffer.

@martinthomson
Copy link
Contributor

That's not a bad idea: you do know what RTCRtpReceiver instances are potentially present once you have called setLocalDescription. That's a pretty significant change to the API though (even if it is just a matter of surfacing a new event).

@juberti
Copy link
Contributor

juberti commented Mar 26, 2015

We could just not surface an event; the only implication would be that rtpreceivers could exist before getting ontrack, which would be a non-issue i think. Some spec tweaking needed, but no app changes needed.

@martinthomson
Copy link
Contributor

Yeah, but handling the case where the peer chooses not to send is awkward: the receiver for a rejected media section would have to silently disappear also.

@juberti
Copy link
Contributor

juberti commented Mar 26, 2015

Not necessarily; it could just become dormant.
Agree that we would have to figure out the details, but I think it would be workable.

@fluffy
Copy link
Contributor

fluffy commented Mar 26, 2015

If you go back to the WebRTC meeting in seattle / china - being able to do this was one of the key motiviations for creating the doohicky objects

@juberti
Copy link
Contributor

juberti commented Mar 26, 2015

I don't think this was an explicit design goal, but we have bumped into this a couple times now and if we can deal with it without wrecking the design I think it will help us solve this and future problems.

@juberti juberti assigned juberti and unassigned fluffy Apr 17, 2015
@juberti juberti modified the milestones: Dallas (IETF 92), IETF 92.5 Interim Apr 17, 2015
@ekr ekr closed this as completed in #150 Jun 16, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants