Mentioning the end-of-candidates indication in a couple sections. #254
Conversation
Specifically, "addIceCandidate" and "Applying a Remote Description".
| @@ -1243,6 +1243,10 @@ candidate:1 1 UDP 1694498815 192.0.2.33 10000 typ host | |||
| and/or pending remote description according to the rules defined for | |||
| Trickle ICE. Connectivity checks will be sent to the new candidate.</t> | |||
|
|
|||
| <t>This method can also be used to provide an end-of-candidates | |||
| indication to the ICE Agent, as defined in | |||
| <xref target="I-D.ietf-ice-trickle"/>.</t> | |||
There was a problem hiding this comment.
Should we be more specific about it being the null value that mean end-of-candidates?
There was a problem hiding this comment.
Isn't this kind of redundant because the ICE agent on side A automatically produces a null candidate, so if you just proxy stuff from A to B, you get what you want?
There was a problem hiding this comment.
Might also want to mention that this applies to all m= sections.
There was a problem hiding this comment.
@pthatcherg I wasn't sure if JSEP was supposed to mention specifics about the API. But I'll change it and see if anyone objects.
@ekr Redundant because "candidate" from the above paragraph can include a null candidate? I assume the meaning of a null candidate needs to be defined here though, since it's not defined in Trickle ICE.
@juberti Done.
There was a problem hiding this comment.
@ekr, I think this is worth spelling out since it wasn't always this way, at least not in the w3c spec.
@taylor-b / @pthatcherg not sure that we should specify null, since that's a bit of a w3c-ism; rather, I think the generic notion that we can supply end-of-candidates here should be sufficient. This would match the advice given in https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-13#section-3.4.1, where it simply says that an event is generated to indicate end-of-candidates.
There was a problem hiding this comment.
@juberti That's what I thought initially. I changed it back.
|
I'm fine this however it ends up. I will r+ this and people can merge it once it is done. Thanks |
|
Just adding a still LGTM |
|
lgtm once my comment from today is addressed |
Mentioning the end-of-candidates indication in a couple sections.
Specifically, "addIceCandidate" and "Applying a Remote Description".