Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There may be an error in 03_Action.ipynb #265

Closed
BDonnot opened this issue Nov 24, 2021 Discussed in #264 · 0 comments · Fixed by #278 or #279
Closed

There may be an error in 03_Action.ipynb #265

BDonnot opened this issue Nov 24, 2021 Discussed in #264 · 0 comments · Fixed by #278 or #279
Labels
bug Something isn't working

Comments

@BDonnot
Copy link
Collaborator

BDonnot commented Nov 24, 2021

Discussed in #264

Originally posted by epetrishchev November 24, 2021
Hello. In the process of getting acquainted with 03_Action.ipynb, I drew attention to this piece of code:

gen_id = 1 # on which generator to apply this action
ratio_curtailment = 0.15 # this is a ratio, between 0.0 and 1.0
# # if not in range [0, 1.0] an "ambiguous action" will be released when calling "env.step"
curtail_act = action_space({"curtail": [(gen_id, ratio_curtailment)]})

and

curtail_act2 = action_space()
curtail_act2.curtail = [(gen_id, amount)]

In theory, these are different ways to do the same thing. But the variable amount is used in the second method, which leads to a change in the power of the generator by 314% of the maximum power.

I apologize if I described the error in the wrong place, can you tell me where to write about the inaccuracies found next time. Thanks.

@BDonnot BDonnot added the bug Something isn't working label Nov 24, 2021
BDonnot added a commit to BDonnot/Grid2Op that referenced this issue Jan 18, 2022
@BDonnot BDonnot linked a pull request Jan 19, 2022 that will close this issue
@BDonnot BDonnot linked a pull request Jan 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant