Instead of macros, use fixtures for XPRESS tests

[flomnes]

Only difficulty : UNITTEST_INIT_MIP() is used in loops, e.g

for (const auto& [paramString, control, paramValue] : params) {
  UNITTEST_INIT_MIP();
  std::string xpressParamString = paramString + " " + paramValue;
  solver.SetSolverSpecificParametersAsString(xpressParamString);
  EXPECT_EQ(paramValue, getter.getStringControl(control));
}

This has been dealt with by replacing the macro with it's content in each of the 3 loops.

for (const auto& [paramString, control, paramValue] : params) {
   MPSolver solver("XPRESS_MIP", MPSolver::XPRESS_MIXED_INTEGER_PROGRAMMING);
   XPRSGetter getter(&solver);
   // ...
}

[pet-mit]

Maybe you can use SetUp() instead of constructor in fixture, that way you can call it multiple time (see google doc)

[flomnes]

Maybe you can use SetUp() instead of constructor in fixture, that way you can call it multiple time (see google doc)

According to this source, constructor/destructor should be used whenever possible.

[pet-mit]

Maybe you can use SetUp() instead of constructor in fixture, that way you can call it multiple time (see google doc)

According to this source, constructor/destructor should be used whenever possible.

then maybe, if possible, add a protected reset() method that resets the MIP ?

[flomnes]

Maybe you can use SetUp() instead of constructor in fixture, that way you can call it multiple time (see google doc)

According to this source, constructor/destructor should be used whenever possible.

then maybe, if possible, add a protected reset() method that resets the MIP ?

For every test, an XpressFixtureMIP is created into the function scope, then destroyed at the end. There is no sharing of a single object among tests.

[pet-mit]

Maybe you can use SetUp() instead of constructor in fixture, that way you can call it multiple time (see google doc)

According to this source, constructor/destructor should be used whenever possible.

then maybe, if possible, add a protected reset() method that resets the MIP ?

For every test, an XpressFixtureMIP is created into the function scope, then destroyed at the end. There is no sharing of a single object among tests.

I meant, a reset() method would maybe help to solve the loop issue

[flomnes]

Maybe you can use SetUp() instead of constructor in fixture, that way you can call it multiple time (see google doc)

According to this source, constructor/destructor should be used whenever possible.

then maybe, if possible, add a protected reset() method that resets the MIP ?

For every test, an XpressFixtureMIP is created into the function scope, then destroyed at the end. There is no sharing of a single object among tests.

I meant, a reset() method would maybe help to solve the loop issue

@pet-mit Since this was only used 3 times (3 for loops), I just copy-pasted the 2 lines of codes each time. I hope the elimination of macros will make it up for this code duplication. Alternatively, I can keep the UNITTEST_INIT_MIP() macro, and use it only in these 3 for loops, and isolate it with #define #undef.