Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Universal Analytics API #29

Merged
merged 1 commit into from Jan 25, 2018
Merged

Switch to Universal Analytics API #29

merged 1 commit into from Jan 25, 2018

Conversation

jessetan
Copy link
Contributor

@jessetan jessetan commented Sep 6, 2017 •
edited

  • Switches from legacy ga.js to new analytics.js, in parrallel with Switch to Universal Analytics API readthedocs.org#3085
  • Google Analytics script element has been moved from the bottom of the page to top of <head> as per Googles instructions
  • Could be made faster by directly adding the Analytics snippet in the html, rather than letting the browser request readthedocs-dynamic-include.js_t, which contains the snippet
  • Not using the Alternative async tracking snippet which should be a bit faster but "can degrade to synchronous loading and execution on IE 9 and older mobile browsers that do not recognise the async script attribute"
  • Needs to be tested by someone with access to RTFD Analytics

This was referenced Sep 6, 2017
Closed
Merged
@davidfischer davidfischer mentioned this pull request Jan 9, 2018
Merged
davidfischer
davidfischer approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@davidfischer davidfischer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

As the description notes, this needs to be deployed with readthedocs/readthedocs.org#3495.

Edit: it needs to be rolled out with changes on the main repo. I have fixed up the original PR readthedocs/readthedocs.org#3085 in readthedocs/readthedocs.org#3495.

@ericholscher ericholscher merged commit e279188 into readthedocs:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfischer davidfischer davidfischer approved these changes

@Blendify Blendify Blendify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jessetan @davidfischer @Blendify @ericholscher