Make middleware not slow and crappy.

core/middleware.py

@@ -81,7 +81,7 @@ def process_request(self, request):
     def process_response(self, request, response):
         #Try and make this match as little as possible.
         if response.status_code == 200:
-            if getattr(request, 'serving_docs', False):
+            if getattr(request, 'add_badge', False):
                 if response.content.find('Read the Docs') == -1:
                     response.content = replace_insensitive(
                         smart_unicode(response.content),

core/views.py

@@ -108,7 +108,6 @@ def serve_docs(request, project_slug, lang_slug, version_slug, filename):
     time.
     """
     # A bunch of janky redirect logic. This should be the last time.
-    request.serving_docs = True
     proj = get_object_or_404(Project, slug=project_slug)
     default_version = proj.get_default_version()
     if not filename:
@@ -129,7 +128,8 @@ def serve_docs(request, project_slug, lang_slug, version_slug, filename):
             'filename': filename
         })
         return HttpResponseRedirect(url)
-    valid_version = proj.versions.filter(slug=version_slug).count()
+    version = proj.versions.filter(slug=version_slug)
+    valid_version = version.count()
     if not valid_version and version_slug != 'latest' and version_slug != 'en':
         url = reverse(serve_docs, kwargs={
             'project_slug': project_slug,
@@ -139,6 +139,8 @@ def serve_docs(request, project_slug, lang_slug, version_slug, filename):
             'filename': os.path.join(version_slug, filename)
         })
         return HttpResponsePermanentRedirect(url)
+    elif valid_version:
+        request.add_badge = version[0].uploaded
     filename = filename.rstrip('/')
     basepath = os.path.join(proj.rtd_build_path, version_slug)
     if 'html' in filename: