Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify URL handling #1385

Closed
ericholscher opened this issue Jun 29, 2015 · 1 comment
Closed

Unify URL handling #1385

ericholscher opened this issue Jun 29, 2015 · 1 comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required Needed: patch A pull request is required Needed: tests Tests are required

Comments

@ericholscher
Copy link
Member

Right now, we generate URL's in lots of different, crazy ways. We have a number of settings that effect this, and they aren't used globally. We should build a proper abstraction around the way we generate URL's, and make sure they take into account the various settings (PRODUCTION_DOMAIN, USE_SUBDOMAIN, single version, languages, etc)
@ericholscher ericholscher added Needed: design decision A core team decision is required Needed: tests Tests are required Status: accepted Needed: patch A pull request is required labels Jun 29, 2015
@ericholscher ericholscher mentioned this issue Jun 29, 2015
Merged
@gregmuellegger gregmuellegger added Improvement Minor improvement to code and removed Status: accepted labels Jul 24, 2015
@ericholscher
Copy link
Member Author

This was written & merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required Needed: patch A pull request is required Needed: tests Tests are required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericholscher @gregmuellegger