Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the docs adds title to Alabaster theme #4630

Closed
Benjamin-Lee opened this issue Sep 11, 2018 · 4 comments
Closed

Read the docs adds title to Alabaster theme #4630

Benjamin-Lee opened this issue Sep 11, 2018 · 4 comments
Labels
Needed: more information A reply from issue author is required Support Support question

Comments

@Benjamin-Lee
Copy link

Details

  • Read the Docs project URL: squiggle.readthedocs.io
  • Build URL (if applicable):
  • Read the Docs username (if applicable):

Expected Result

expected

There is no title in the top left.

This issue persists even though my conf.py contains the following:

html_theme_options = {
    # "fixed_sidebar": True,
    "logo_name": False,
    "sidebar_collapse": False,
    "show_related": True,
    "description": "DNA Sequence visualization for humans."
}

Actual Result

actual

The title of the project is in the top left.

@stsewd stsewd added the Support Support question label Sep 11, 2018
@agjohnson
Copy link
Contributor

Read the Docs doesn't do anything special to context data or really anything special at all to Alabaster. Not sure what would be changing this -- you can try a full wipe of the project, in the case that you recently changed the config option. Otherwise, let us know if you come across any other information that would help determine if this is a bug.

@agjohnson agjohnson added the Needed: more information A reply from issue author is required label Sep 17, 2018
@stsewd
Copy link
Member

stsewd commented Nov 20, 2018

Does the title show when building locally?

@stsewd
Copy link
Member

stsewd commented Nov 21, 2018

I just build your docs locally (inside and outside rtd), the logo_name setting is working as expected. Also, I can see that you are using logo_name to True https://github.com/Lab41/squiggle/blob/e0482237ced49750b5f1b0912079b5a47177f0d4/docs/conf.py#L91.

I'm closing, feel free to reopen with more information.

@stsewd stsewd closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: more information A reply from issue author is required Support Support question
Projects
None yet
Development

No branches or pull requests

3 participants