Add redirect to specific page in default language/version (#282) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I suggested in #282, this adds a URL pattern that can redirect to a specific page under the default version. Using "/page/..." either on readthedocs.org or a subdomain redirects. Note that the redirect goes to "/docs/<project_slug>/..." even on subdomains. This could be fixed by using a different URL pattern name for the subdomain URLs and specifically requesting that in the call to `reverse()`.
|
Bah sorry I forgot about this. Will look at it this weekend & get it merged. |
ericholscher
added a commit
that referenced
this pull request
Nov 13, 2012
Add redirect to specific page in default language/version (#282)
|
Awesome; thanks!! |
|
Yea, I had to add a basic patch to the subdomain stuff, but it should be On Mon, Nov 12, 2012 at 9:45 PM, Adrian Sampson notifications@github.comwrote:
Eric Holscher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I suggested in #282, this adds a URL pattern that can redirect to a specific
page under the default version. Using "/page/..." either on readthedocs.org or
a subdomain redirects.
Note that the redirect goes to "/docs/<project_slug>/..." even on subdomains.
This could be fixed by using a different URL pattern name for the subdomain
URLs and specifically requesting that in the call to
reverse().