Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TEMPLATE_LOADERS since it's the default #3469

Merged
merged 1 commit into from Jan 4, 2018
Merged

Remove TEMPLATE_LOADERS since it's the default #3469

merged 1 commit into from Jan 4, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 2, 2018

@humitos
Copy link
Member Author

humitos commented Jan 2, 2018

This has failed with an unrelated issue (npm). Restarting the job.

agjohnson
agjohnson approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I restarted the tests again, they were failing on another unrelated problem with Travis

@humitos humitos merged commit 97e2c26 into master Jan 4, 2018
@humitos humitos deleted the humitos/settings/template-loaders branch January 4, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@humitos @ericholscher @agjohnson