Initialize local variable before using it #5342

stsewd · 2019-02-22T16:58:19Z

If the try..except block fails and there is not
results, we end up with updated undefined.

If the try..except block fails and there is not results, we end up with `updated` undefined.

ericholscher

Surprised tests or linting didn't catch this. Is there a good way to catch this kind of stuff in the future?

stsewd · 2019-02-22T17:48:36Z

Surprised tests or linting didn't catch this. Is there a good way to catch this kind of stuff in the future?

More tests/coverage p: This is still tricky for static analyzers I guess

stsewd added 2 commits February 22, 2019 11:57

Initialize local variable before using it

b2d248a

If the try..except block fails and there is not results, we end up with `updated` undefined.

Isort

f07c519

stsewd requested a review from a team February 22, 2019 16:59

ericholscher approved these changes Feb 22, 2019

View reviewed changes

humitos merged commit fab3be9 into readthedocs:master Feb 25, 2019

stsewd deleted the initialize-local-variable branch February 25, 2019 13:06

Provide feedback