Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add elements with JavaScript, add with Sphinx writer #530

Closed
agjohnson opened this issue Dec 27, 2017 · 3 comments
Closed

Don't add elements with JavaScript, add with Sphinx writer #530

agjohnson opened this issue Dec 27, 2017 · 3 comments
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@agjohnson
Copy link
Collaborator

We shouldn't be adding additional elements via JavaScript when we have access to running Sphinx extensions. An extension could output the additional elements around tables and citations that we use for styling.
@agjohnson agjohnson added the Needed: design decision A core team decision is required label Dec 27, 2017
@agjohnson agjohnson mentioned this issue Dec 27, 2017
Merged
@Blendify
Copy link
Member

Blendify commented Jan 7, 2018

👍

@stsewd stsewd added the Improvement Minor improvement to code label Oct 8, 2020
@humitos
Copy link
Member

humitos commented Aug 12, 2024

Where are we adding these elements via JavaScript? Can you link to the code? Is this issue still valid?

@humitos
Copy link
Member

humitos commented Aug 12, 2024

OK. I think I found what this issue refers to, and it's dup of #783

@humitos humitos closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@humitos @agjohnson @stsewd @Blendify