New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added `.admonition` to the CSS #462

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
2 participants
@evildmp
Contributor

evildmp commented Sep 14, 2017

FIxes #461

Now generic admonitions are styled too.

Proof of concept

Broken version

screenshot 2017-09-14 00 18 36

Fixed version

screenshot 2017-09-14 17 34 59

Added `.admonition` to the CSS
Now generic admonitions are styled too.
@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Sep 14, 2017

Contributor

Can you please revert d366a20 other then that looks good.

Contributor

Blendify commented Sep 14, 2017

Can you please revert d366a20 other then that looks good.

@Blendify Blendify self-requested a review Sep 14, 2017

@evildmp

This comment has been minimized.

Show comment
Hide comment
@evildmp

evildmp Sep 14, 2017

Contributor

@Blendify Thanks for the quick review.

Now reverted. I don't understand though - the repository contained the compiled files; don't they need to be updated too?

Contributor

evildmp commented Sep 14, 2017

@Blendify Thanks for the quick review.

Now reverted. I don't understand though - the repository contained the compiled files; don't they need to be updated too?

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Sep 14, 2017

Contributor

Yes, but for code reviews, it does not work well. It works better if one of us updates it every so often.

Contributor

Blendify commented Sep 14, 2017

Yes, but for code reviews, it does not work well. It works better if one of us updates it every so often.

@Blendify Blendify merged commit d24f7ca into rtfd:master Sep 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evildmp

This comment has been minimized.

Show comment
Hide comment
@evildmp

evildmp Sep 15, 2017

Contributor

Thanks. I guess that means it's not possible to do a pip install -e on the GitHub repository then for a working copy - I'll have to wait until the next release.

Contributor

evildmp commented Sep 15, 2017

Thanks. I guess that means it's not possible to do a pip install -e on the GitHub repository then for a working copy - I'll have to wait until the next release.

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Sep 15, 2017

Contributor
Contributor

Blendify commented Sep 15, 2017

travismiller added a commit to broco1974/couscous-template-readthedocs that referenced this pull request Dec 4, 2017

Merge commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3' into rtfd
* commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3': (253 commits)
  Add pygments_style to theme.conf
  Document new theme option
  Add option to layout.html
  Update theme.conf
  Apply clearfix on breadcrumbs
  Follow-up grunt for #472 (#476)
  Only change current if a matching link is found (#472)
  Add a couple of badge icons to readme (#471)
  Add Sphinx Framework for PyPi (#470)
  Fix error in setup entry points (#466)
  Added `.admonition` to the CSS (#462)
  Use explicit UTF8 encoding (#452)
  Add missing pygments css link
  Convert underscores to dashes.
  Reflect language in lang attribute.
  Replace master with v0.2.5 in README.rst
  Add missing dependency in dev setup: sphinxcontrib-httpdomain (#431)
  Finalized #418 (#433)
  Added a link to the Sphinx documentation about setuptools entry points
  Added setuptools entry point for Sphinx
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment