Added .admonition to the CSS
#462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now generic admonitions are styled too.
|
Can you please revert d366a20 other then that looks good. |
|
@Blendify Thanks for the quick review. Now reverted. I don't understand though - the repository contained the compiled files; don't they need to be updated too? |
|
Yes, but for code reviews, it does not work well. It works better if one of us updates it every so often. |
Blendify
approved these changes
Sep 14, 2017
|
Thanks. I guess that means it's not possible to do a |
|
Someone with direct commit rights can update the CSS soon.
We recently changed how we decided to do this so we are still working some
stuff out.
Aaron Carlisle
Picture taker | Bit cruncher | Pixel pusher | Document writer |
Project administrator for the Blender 3D Documentation Project
…On Fri, Sep 15, 2017 at 3:20 AM, Daniele Procida ***@***.***> wrote:
Thanks. I guess that means it's not possible to do a pip install -e on
the GitHub repository then for a working copy - I'll have to wait until the
next release.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#462 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOeua8boHrhZuHgkYHQdoe8__EyE1ce1ks5siiUugaJpZM4PXx8o>
.
|
travismiller
pushed a commit
to broco1974/couscous-template-readthedocs
that referenced
this pull request
Dec 4, 2017
* commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3': (253 commits) Add pygments_style to theme.conf Document new theme option Add option to layout.html Update theme.conf Apply clearfix on breadcrumbs Follow-up grunt for readthedocs#472 (readthedocs#476) Only change current if a matching link is found (readthedocs#472) Add a couple of badge icons to readme (readthedocs#471) Add Sphinx Framework for PyPi (readthedocs#470) Fix error in setup entry points (readthedocs#466) Added `.admonition` to the CSS (readthedocs#462) Use explicit UTF8 encoding (readthedocs#452) Add missing pygments css link Convert underscores to dashes. Reflect language in lang attribute. Replace master with v0.2.5 in README.rst Add missing dependency in dev setup: sphinxcontrib-httpdomain (readthedocs#431) Finalized readthedocs#418 (readthedocs#433) Added a link to the Sphinx documentation about setuptools entry points Added setuptools entry point for Sphinx ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #461
Now generic admonitions are styled too.
Proof of concept
Broken version
Fixed version