Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitlab group to Gitlab breadcrumbs #641

Closed
wants to merge 1 commit into from
Closed

Add gitlab group to Gitlab breadcrumbs #641

wants to merge 1 commit into from

Conversation

boredstiff
Copy link

Gitlab has a concept of groups that are very commonly used in organizations, which in this url is positionally equivalent to the 'gitlab_user' key. However, for clarity's sake, I've added the 'gitlab_group' key which makes more sense.

Example of groups: https://gitlab.com/gitlab-org/ci-cd

Gitlab has a concept of groups that are very commonly used in organizations, which in this url is positionally equivalent to the 'gitlab_user' key. However, for clarity's sake, I've added the 'gitlab_group' key which makes more sense.
@boredstiff
Copy link
Author

boredstiff commented May 15, 2018

Build: https://travis-ci.org/rtfd/sphinx_rtd_theme/builds/379441601?utm_source=github_status&utm_medium=notification

I'm not sure where this 'filter' is supposed to be added, but I can't see anything indicative in the source.

I have a feeling it may be an issue with adding a key and the building happening on the Travis server trying to use a key it didn't previously have, in which case I'm not sure how I can submit a fix to that.

Happy to hear any tips.

@Blendify
Copy link
Member

I don't think this is needed we could rename gitlab_user to something more appropriate but the API breakage is not worth it.

@Blendify Blendify closed this Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants