Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical scroll on Footer menu #707

Merged
merged 4 commits into from
Dec 19, 2018

Conversation

dojutsu-user
Copy link
Member

Fixes readthedocs/readthedocs.org#4496

Result:

  1. When there are too many versions and translations
    ezgif-4-045218f8984e

  2. When there are limited versions and translations
    ezgif-4-8a20fdd2583f

@jessetan
Copy link
Contributor

jessetan commented Dec 18, 2018

This is probably the same as #575

sass/_theme_badge.sass Outdated Show resolved Hide resolved
Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this fixes #575 and doesn't suffer from the issues we saw and fixed in #626. In my testing in Firefox and Chrome it looked good and functioned correctly.

I don't want to override @jessetan's opinion though and I'd like to get toward a consensus.

sass/_theme_badge.sass Outdated Show resolved Hide resolved
jessetan and others added 2 commits December 19, 2018 15:55
Copy link
Contributor

@jessetan jessetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidfischer davidfischer merged commit 73d3029 into readthedocs:master Dec 19, 2018
@dojutsu-user dojutsu-user deleted the add-vertical-scroll branch December 19, 2018 16:41
@humitos
Copy link
Member

humitos commented Dec 20, 2018

Just a comment.

I think there is only one difference with the current behavior (but not sure if it's browser dependent): in current versions of documentation with alabaster theme the vertical does not appear when scroll is not needed and in the GIF uploaded to this pull request, it does appear even when there is nothing to scroll.

captura de pantalla_2018-12-20_14-54-50

@davidfischer
Copy link
Contributor

I think there is only one difference with the current behavior (but not sure if it's browser dependent): in current versions of documentation with alabaster theme the vertical does not appear when scroll is not needed and in the GIF uploaded to this pull request, it does appear even when there is nothing to scroll.

If I'm understanding this correctly, you're talking about the scrollbar appearing or not. I believe this is browser dependent. Chrome allowed changing some appearance on scrollbars while Firefox did not. However, I believe that is changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants