-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexbox keywords #13
Comments
Working on these currently, so nobody else picks them up :). |
See #58 |
Thanks, that's my PR when I just asking Richard some questions :P Just though I'd post here now that I've done a few more in case nobody checked the PRs |
Haha, right. Somehow I missed that it was you. Looking forward to this. |
Having an issue with flex-flow, and likely flex. With flex-flow, it can accept either flex-direction, flex-row, or both, in any order since the keywords are unique. My problem is, with most multi-parameter CSS properties, they have a defined order. For example, with text-shadow, you must do "color" followed by "values" or vice versa. Also, you must have both to specify color (you can't do With flex-flow though, you can do any combination including omitting either, i.e
Should all be valid in your CSS file! I'm having trouble figuring this out since in Elm the order of inputs is defined and type specific. And, even if I force the order, I still have to account for leaving one out, which I can't seem to figure out using Maybe/Nothing with an extensible record:
Or something of the like doesn't seem to play nice, and would still require the user to do Any comments or suggestions welcome! Thanks, Nick |
@NicholasGW I'm pretty new to Elm, but at least for now, what about simply not implementing shorthands? Have you made any progress so far? I'd like to help to make this happen. |
Cool, totally missed that! I guess this can be closed then? @rtfeldman |
How do you set |
@jgillich right you are! I think it might work by virtue of using a string but there definitely should be a defined function for it like there is for inline or inline-block etc. Care to take a stab? |
I've decided to close all the |
These are keywords necessary to cover Flexbox
alignItems
alignSelf
flex
flexBasis
flexDirection
flexFlow
flexGrow
flexShrink
flexWrap
The text was updated successfully, but these errors were encountered: