Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Mixin to Style #253

Merged
merged 2 commits into from
Apr 16, 2017
Merged

Rename Mixin to Style #253

merged 2 commits into from
Apr 16, 2017

Conversation

rtfeldman
Copy link
Owner

It's always been pretty weird that backgroundColor returns something called Mixin. My thinking was "these work like Mixins from Sass/Stylus/etc" but really what I want to say is just "these compose" and calling them Mixins seems unnecessary in retrospect.

What I should have said in the first place was "backgroundColor returns a Style, and you can compose Styles to make other Styles"

@rtfeldman rtfeldman merged commit fb6915e into master Apr 16, 2017
@rtfeldman rtfeldman deleted the mixin-to-style branch April 16, 2017 21:23
@mordrax
Copy link

mordrax commented Jun 10, 2017

w.r.t this PR, the following err now makes alot of sense:

The type annotation for `children` says it is a:

    List Preprocess.Snippet -> Style

But the definition (shown above) is a:

    List Preprocess.Snippet -> Css.Preprocess.Mixin

This was because i included the latest master branch as a local src but didn't know to clean out elm-stuff/packages...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants