compileToStringSync returns empty string on error #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published to npm as 5.0.6 |
rogeriochaves
added a commit
to rogeriochaves/esbuild-plugin-elm
that referenced
this pull request
Jun 19, 2022
I want to be able to display the error message on the screen, for that I need to capture the error message produced during a compilation error, but this is not possible because the sync function from node-elm-compiler returns just a hardcoded string, as you can see here: rtfeldman/node-elm-compiler#110 Since we are already in an async function, we might as well just use await here and get the proper error message
|
Hey there, but why returning a hardcoded error string? Shouldn't we return the full error message? I needed that so I opened a pull request in esbuild-plugin-elm as well, but maybe the change should be made here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified https://github.com/phenax/esbuild-plugin-elm/ to use
compileToStringSyncand noticed our tools stopped being able to tell when Elm compilation failed.Traced it back to us not handling the compiler process exit status on
compileToStringSync.