Fix #391 #404
Merged
Fix #391 #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduce bug from issue: #391
rtfeldman
approved these changes
Jan 7, 2020
| @@ -103,6 +103,8 @@ function findTests( | |||
| return new Promise(function(resolve, reject) { | |||
| function finish() { | |||
| const args = elmVersion ? ['--elm-version=' + elmVersion] : []; | |||
| // TODO: Have elmi-to-json only read test file paths, not all paths. | |||
| // args = args.concat(testFilePaths); | |||
There was a problem hiding this comment.
More context on this: it would be more efficient to have elmi-to-json only read the .elmi files that will be used.
However, we couldn't determine how to do that, and didn't want to block the fix on that. Instead, we're filtering them out after the fact below.
|
I wonder if we should add a test to prevent another regression? Don't have context enough to know if that makes sense, so let me know! |
|
I think it does make sense, and we sort-of did a thing like that, in that we modified an existing test to reproduce this problem. The relevant line that enabled this was this: |
|
Oh, didn't realize that was what that was! Great! |
|
<3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with @rtfeldman