fix --compiler flag #438
Merged
fix --compiler flag #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By resolving _after_ we use which to locate binaries on PATH we can actually use binary names (that are on PATH) as well as paths to binaries. This commit fixes a bug I introduced in rtfeldman#330
|
Errors are to do with the fact that you cannot just execute a text file on windows. |
hopefully this will fix this test for windows.
Man! I dislike developing on windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By resolving after we use which to locate binaries on PATH we can
actually use binary names (that are on PATH) as well as paths to
binaries.
This commit fixes a bug I introduced in #330