Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen constraint for elm-solve-deps-wasm #636

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lishaduck
Copy link

@lishaduck lishaduck commented Jul 9, 2024

Allow elm-solve-deps-wasm v2.

CC: @lydell.

Otherwise, npm whines.
I'm rather surprised this didn't complain before.

To be clear: this kept the same versions locked, it just updated the metadata.
@lydell
Copy link
Collaborator

lydell commented Jul 9, 2024

Is this to save space in node_modules/ for those who install both elm-review and elm-test?

@lishaduck
Copy link
Author

lishaduck commented Jul 9, 2024

Is this to save space in node_modules/ for those who install both elm-review and elm-test?

Yeah. If we allow both versions, then it'll install the latest.
I did the same in elm-review. This way, it's not breaking, we don't force anyone to upgrade. However, npm will default to v2.

If you install elm-test, then elm-review, currently you'll only get one, outdated elm-solve-deps-wasm, but if you install elm-review, then elm-test, currently you'll get two, one outdated and one new. This fixes that so that npm will always default to the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants