Fix non truthy custom merger results #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crudh any news regarding this?? |
|
@donnanicolas sorry, I don't think this is a high priority project for @rtfeldman anymore after his switch to Elm. I don't have any access to commit changes and I no longer use the library. I just jumped in since I contributed the custom mergers, so it seemed like my mess to clean up 😄 |
|
@donnanicolas I was given collaborator access so I'll merge this now. It will be in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging with a custom merger ignores all non truthy results. It should only ignore
undefined. See issue #244.Since this changes the behavior of custom mergers a major version bump is warranted.
This fixes #244.