Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong bower.json::main #53

Closed
fedescarpa opened this issue Jan 31, 2016 · 2 comments
Closed

Wrong bower.json::main #53

fedescarpa opened this issue Jan 31, 2016 · 2 comments
Labels
enhancement

Comments

@fedescarpa
Copy link

bower.json::main#L:30 should be dist instead of src

Using wiredep, it throws an error on browser because require function is not defined
@fedescarpa fedescarpa changed the title bower.json::main fail Wrong bower.json::main Jan 31, 2016
@fedescarpa
Copy link
Author

Thank you for the quick fix.

Would you mind putting the ./dist/diff2html.css file into the main too?

...
    "main": [
        "./dist/diff2html.js",
        "./dist/diff2html.css",
    ]
...

@rtfpessoa
Copy link
Owner

Ok, I thought it was like npm. Just read the docs, and updated.
Thanks for the suggestion.

rtfpessoa added a commit that referenced this issue Feb 1, 2016
@rtfpessoa
Improve bower.json main field
6abfbdb 
* Add dist css and js to main field

Thanks to @fedescarpa
Closes #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtfpessoa @fedescarpa