New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hand in file/line to generic line template #483

Merged

rtfpessoa merged 1 commit into rtfpessoa:master from phikes:hand-in-file-line-to-template

Mar 7, 2023

Contributor

phikes commented Mar 5, 2023

This PR hands in the file and line objects into the "generic-line" template as variable. See this issue for more context.

Some of the questions here include:

are the tests enough like this or should we add tests for overwriting templates which consume these variables?
Should we hand in the "main entity" (or entities) to other templates as well? (I only needed the file/line in the generic line template)

Thanks again for being friendly and open about my issue and proposal! :-)


          feat: hand in file/line to generic line template

0d314ae

rtfpessoa merged commit 6851537 into rtfpessoa:master

Contributor Author

phikes commented Mar 7, 2023

phikes had a problem deploying to dev

April 6, 2023 19:26

— with

GitHub Actions Failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment