Skip to content

Commit

Permalink
iotests: Make verify_virtio_scsi_pci_or_ccw() public
Browse files Browse the repository at this point in the history
It has no internal callers, so its only use is being called from
individual test cases. If the name starts with an underscore, it is
considered private and linters warn against calling it. 256 only gets
away with it currently because it's on the exception list for linters.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230525124713.401149-12-kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
kevmw committed May 30, 2023
1 parent 8823407 commit bc05c63
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/qemu-iotests/256
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import os
import iotests
from iotests import log

iotests._verify_virtio_scsi_pci_or_ccw()
iotests.verify_virtio_scsi_pci_or_ccw()

iotests.script_initialize(supported_fmts=['qcow2'])
size = 64 * 1024 * 1024
Expand Down
2 changes: 1 addition & 1 deletion tests/qemu-iotests/iotests.py
Original file line number Diff line number Diff line change
Expand Up @@ -1421,7 +1421,7 @@ def _verify_virtio_blk() -> None:
if 'virtio-blk' not in out:
notrun('Missing virtio-blk in QEMU binary')

def _verify_virtio_scsi_pci_or_ccw() -> None:
def verify_virtio_scsi_pci_or_ccw() -> None:
out = qemu_pipe('-M', 'none', '-device', 'help')
if 'virtio-scsi-pci' not in out and 'virtio-scsi-ccw' not in out:
notrun('Missing virtio-scsi-pci or virtio-scsi-ccw in QEMU binary')
Expand Down

0 comments on commit bc05c63

Please sign in to comment.