Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change QUIC backend from 'aioquic' to 'qh3' (fork of aioquic) #1000

Closed
wants to merge 1 commit into from

Conversation

Payne-X6
Copy link

@Payne-X6 Payne-X6 commented Nov 1, 2023

The aioquic repository is almost unmaintained. The last push is 4 months old, while there are 20 PRs waiting for approval. Its fork qh3 might be a suitable replacement. It is actively maintained and fixes several deficiencies of the aioquic library already.
Please consider choosing qh3 as a backend for QUIC.

Signed-off-by: Jan Hák <jan.hak@nic.cz>
@rthalley
Copy link
Owner

rthalley commented Nov 1, 2023

While I am concerned about the health of aioquic, I'm not ready to switch away from it yet.

@salzmdan
Copy link
Contributor

salzmdan commented Nov 2, 2023

Yes, we fully understand your position.

Our motivation for the library change was aiortc/aioquic#377, which prevents using dnspython with QUIC for testing of a DNS server.

@rthalley
Copy link
Owner

rthalley commented Nov 2, 2023

It may be that with a little reorganizing we can make the QUIC module selectable or have it probe, which (so long as the API doesn't diverge) would let you do your testing. It's a tough place to be in, as on the one hand I'm not sure what the future of QUIC on Python will be and don't want to be changing things many times, but also part of the reason I put QUIC support into dnspython when I did was to facilitate server development and other early adopters. (The other main reason being to try to learn something about QUIC myself, and I needed to learn by doing.)

@rthalley
Copy link
Owner

rthalley commented Nov 3, 2023

I just pushed a "qh3" branch that will look for qh3 first and then aioquic (the idea being that if qh3 is installed, it is your preference). Assuming you can work from dnspython's source and not a release, this will let you do your testing with qh3 while not committing us to a change.

@rthalley
Copy link
Owner

rthalley commented Nov 6, 2023

I'm closing this PR, because if we do add qh3 support to the mainline it will probably be via the qh3 branch solution and not this way, unless aioquic gets officially abandoned or transitioned. I will be keeping a close eye on things! Thanks!

@rthalley rthalley closed this Nov 6, 2023
@salzmdan
Copy link
Contributor

salzmdan commented Nov 6, 2023

Thank you!

@Ousret
Copy link

Ousret commented Nov 13, 2023

Hello,

FYI I have plans for dnspython to be integrated in urllib3.future soon enough.
It would tremendously help to have qh3 in the tree. I am available if there are concerns, demands, or anything else. We can ensure compatibility with integration testing.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants