Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EDE retrieval helper [#969]. #1056

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add EDE retrieval helper [#969]. #1056

merged 1 commit into from
Feb 20, 2024

Conversation

rthalley
Copy link
Owner

This adds a helper to extract EDE options from the EDNS0 options list. I think this is all we need to meet [#969], as resolver exceptions contain the message as well.

@bwelling
Copy link
Collaborator

This API looks reasonable, but I think it would be better if there were a more general version that returned all of the options of a specified type, and extended_errors was be a trivial wrapper around that. Right now, any code that wants to look at a single option type needs to iterate over all of the options.

@rthalley
Copy link
Owner Author

Good idea, and easily done.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ab3d16) 94.08% compared to head (52414ef) 94.08%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files         142      142           
  Lines       13141    13145    +4     
  Branches     2532     2533    +1     
=======================================
+ Hits        12364    12368    +4     
  Misses        463      463           
  Partials      314      314           
Flag Coverage Δ
unittests 94.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rthalley rthalley merged commit 6e4bb27 into main Feb 20, 2024
9 checks passed
@rthalley rthalley deleted the ede-sugar branch March 27, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants