Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace h3 parameter with http_version. #1068

Merged
merged 1 commit into from Mar 21, 2024

Conversation

bwelling
Copy link
Collaborator

This allows more flexibility; clients can specify which http version they want, or use the default.

This allows more flexibility; clients can specify which http version
they want, or use the default.
@bwelling
Copy link
Collaborator Author

Note that this doesn't add any new tests, because it's unclear how to test. The optimal testing strategy would use nanonameserver, but it doesn't support DoH. Asking real nameservers on the Internet doesn't work, since there's no good way to know what version was used. It might be possible to do some complicated mocking, but I'm not sure how.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.95%. Comparing base (23a6cd2) to head (ba29394).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
+ Coverage   93.94%   93.95%   +0.01%     
==========================================
  Files         143      143              
  Lines       13377    13389      +12     
  Branches     2596     2596              
==========================================
+ Hits        12567    12580      +13     
  Misses        477      477              
+ Partials      333      332       -1     
Flag Coverage Δ
unittests 93.91% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rthalley rthalley merged commit 3238267 into rthalley:main Mar 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants