Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSSEC signer #866

Merged
merged 36 commits into from
Dec 13, 2022
Merged

DNSSEC signer #866

merged 36 commits into from
Dec 13, 2022

Conversation

jschlyter
Copy link
Contributor

@jschlyter jschlyter commented Dec 7, 2022

RRset signer

This PR implements a RRset signer via the following new functions:

  • make_dnskey() - convert a cryptography public key to DNSKEY Rdata (also available as Create DNSKEY from public key #864)
  • sign() - Sign RRset using a cryptography private key

Implementations Notes

The logic for calculating signature data (_make_rrsig_signature_data()) is shared between _validate_rrsig() and _sign().

Signer timestamps can be specified as datetime, string in YYYYmmddHHMMSS format or as an int/float.

The signer implements all RSA, DSA, ECDSA and EDDSA algorithms, but does not implement GOST.

Testing

  • Key test vectors generated using OpenSSL has been added to tests/keys.py. Matching DNSKEY RRs was generated using Knot DNS.
  • Signature testing implemented for all algorithms (generate key, sign, validate)

Closes #864
Discussed in #862

@rthalley rthalley merged commit 6fa40bd into rthalley:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants