Merge pull request #59 from ygageot/master

Identify activation

README.md

@@ -145,6 +145,7 @@ the accessories folder. See for example [switch](src/accessories/switch.js) or [
 the accessories factory in `accessories.js` aware of you new device type. The factory receives the entire response of the get-sensors call from the HomeWizard which lists all devices.
 
 # Changelog
+- 0.0.58 - Identity activation for lights and switches
 - 0.0.57 - Fix issue where dimmers would go in dim mode when you turn them on again
 - 0.0.56 - Doorbell like a switch
 - 0.0.55 - eslint reactivation and push request activated by default

package.json

@@ -1,6 +1,6 @@
 {
   "name": "homebridge-homewizard",
-  "version": "0.0.57",
+  "version": "0.0.58",
   "description": "Plugin for Homebridge to communicate with HomeWizard",
   "author": "Raymond de Wit",
   "license": "ISC",

src/accessories/accessory.js

@@ -24,7 +24,8 @@ export class HomeWizardBaseAccessory {
     informationService
       .setCharacteristic(this.hap.Characteristic.Manufacturer, this.manufacturer)
       .setCharacteristic(this.hap.Characteristic.Model, this.model)
-      .setCharacteristic(this.hap.Characteristic.SerialNumber, this.serialNumber);
+      .setCharacteristic(this.hap.Characteristic.SerialNumber, this.serialNumber)
+      .setCharacteristic(this.hap.Characteristic.Identify, true);
     this.services.push(informationService);
   }
 

src/accessories/philips-hue.js

@@ -15,8 +15,8 @@ export class HomeWizardPhilipsHue extends HomeWizardBaseAccessory {
   setupServices() {
     // Setup services
     const lightbulbService = new this.hap.Service.Lightbulb();
-    lightbulbService
-      .getCharacteristic(this.hap.Characteristic.On)
+    this.onChar = lightbulbService.getCharacteristic(this.hap.Characteristic.On);
+    this.onChar
       .on('set', this.setPowerState.bind(this))
       .on('get', this.getPowerState.bind(this));
 
@@ -120,4 +120,14 @@ export class HomeWizardPhilipsHue extends HomeWizardBaseAccessory {
       callback(error, 100);
     });
   }
+
+  identify(callback) {
+    this.log(`Identify ${this.name}...`);
+    const previous = this.onChar.value;
+    this.onChar.setValue(1 - previous);
+    setTimeout(function (me, value) {
+      me.onChar.setValue(value);
+    }, 1000, this, previous);
+    callback();
+  }
 }

src/accessories/radiator-valve.js

@@ -32,7 +32,10 @@ export class HomeWizardRadiatorValve extends HomeWizardBaseAccessory {
       .setCharacteristic(this.hap.Characteristic.CurrentHeatingCoolingState, this.hap.Characteristic.CurrentHeatingCoolingState.HEAT);
 
     valveService
-      .setCharacteristic(this.hap.Characteristic.TargetHeatingCoolingState, this.hap.Characteristic.TargetHeatingCoolingState.AUTO);
+      .setCharacteristic(this.hap.Characteristic.TargetHeatingCoolingState, this.hap.Characteristic.TargetHeatingCoolingState.HEAT);
+
+    valveService
+      .getCharacteristic(this.hap.Characteristic.TargetHeatingCoolingState).props.validValues = [this.hap.Characteristic.TargetHeatingCoolingState.HEAT];
 
     valveService
       .setCharacteristic(this.hap.Characteristic.TemperatureDisplayUnits, this.hap.Characteristic.TemperatureDisplayUnits.CELSIUS);

src/accessories/switch.js

@@ -45,8 +45,8 @@ export class HomeWizardSwitch extends HomeWizardBaseAccessory {
         break;
     }
 
-    service
-      .getCharacteristic(this.hap.Characteristic.On)
+    this.onChar = service.getCharacteristic(this.hap.Characteristic.On);
+    this.onChar
       .on('set', this.setPowerState.bind(this))
       .on('get', this.getPowerState.bind(this));
 
@@ -123,4 +123,14 @@ export class HomeWizardSwitch extends HomeWizardBaseAccessory {
       callback(error);
     });
   }
+
+  identify(callback) {
+    this.log(`Identify ${this.name}...`);
+    const previous = this.onChar.value;
+    this.onChar.setValue(1 - previous);
+    setTimeout(function (me, value) {
+      me.onChar.setValue(value);
+    }, 1000, this, previous);
+    callback();
+  }
 }