fix CI: use an older nightly on the x86_64 build #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(for a more permanent solution that doesn't require nightly, you could also check out https://github.com/dtolnay/trybuild) |
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Nov 7, 2019
269: [v0.4.x] CI: pin to an older nightly r=korken89 a=japaric to workaround compiletest-rs being broken on recent nightlies this is a backport of #267 and it's required to land #265 I'm not backporting #268 (compiletest -> trybuild) because this branch has compile-pass tests which depend on compiletest and can't be ported to trybuild Co-authored-by: Jorge Aparicio <jorge@japaric.io>
bors bot
added a commit
that referenced
this pull request
Nov 13, 2019
269: [v0.4.x] CI: pin to an older nightly r=korken89 a=japaric to workaround compiletest-rs being broken on recent nightlies this is a backport of #267 and it's required to land #265 I'm not backporting #268 (compiletest -> trybuild) because this branch has compile-pass tests which depend on compiletest and can't be ported to trybuild Co-authored-by: Jorge Aparicio <jorge@japaric.io>
andrewgazelka
pushed a commit
to andrewgazelka/cortex-m-rtic
that referenced
this pull request
Nov 3, 2021
287: Fix common uses of INSERT AFTER with .bss and .text r=adamgreig a=mattico Fixes rtic-rs#267 Fixes rtic-rs#266 This fixes two related issues. 1. Named sections are often inserted after `.bss` or `.text` in order to have them handled as if they were part of that section. Defining the start/end symbols outside of the section allows this to work. 2. Uninitialized C statics will end up as common symbols which end up in the COMMON input section. If this section is orphaned, it will likely end up placed after `.bss`. C code often expects these statics to be zero initialized. The first change would cause these symbols to be placed before `__ebss` so they will get zeroed by the reset handler. Explicitly placing the common symbols into `.bss` ensures this happens. Users who want uninitialized symbols should use the `.uninit` section. See rust-embedded/cortex-m-rt#287 (comment) Co-authored-by: Matt Ickstadt <mattico8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.