Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cortex-m-rtic-trace #90

Open
Tracked by #100
tmplt opened this issue Dec 12, 2021 · 3 comments
Open
Tracked by #100

Deprecate cortex-m-rtic-trace #90

tmplt opened this issue Dec 12, 2021 · 3 comments
Labels
enhancement New feature or request upstream This issue is an upstream issue
Milestone

Comments

@tmplt
Copy link
Member

tmplt commented Dec 12, 2021

A goal of RTIC Scope is to be as non-intrusive as possible which ultimately requires us to remove the use of cortex-m-rtic-trace: probe-rs should be able to configure almost everything instead. Ideally, the only thing the user should need to do is declare a [package.metadata.rtic-scope] block in Cargo.toml 1 (or equivalent file). Some functionality must be moved upstream into RTIC itself such as the variable that the DWT monitors for software tracing purposes. The user may also have to set a flag in order to signal which RTIC tasks they want to trace, e.g. #[task(trace = true, ...)], but this is more of a boon as it enables the user to trace a subset of tasks.

Footnotes

  1. for example:

    [package.metadata.rtic-scope]
    # necessary information for RTIC metadata recovery
    pac_name = "stm32f4"
    pac_features = ["stm32f401"]
    pac_version = "0.13"
    interrupt_path = "stm32f4::stm32f401::Interrupt"
    
    # ITM/DWT/TPIU parameters that probe-rs could set that cortex-m-rtic-trace currently handles.
    tpiu_freq = 16000000
    tpiu_baud = 115200
    dwt_enter_id = 1
    dwt_exit_id = 2
    lts_prescaler = 1
    
    # for debugging purposes: reading from the embedded trace buffer via probe-rs seems to yield a lot of broken packages.
    # To be investigated.
    expect_malformed = true
    
@tmplt tmplt added enhancement New feature or request upstream This issue is an upstream issue labels Dec 12, 2021
@tmplt tmplt added this to the v1.0.0 milestone Dec 12, 2021
@tmplt
Copy link
Member Author

tmplt commented Dec 12, 2021

CC @Yatekii @perlindgren: future PRs to both probe-rs and cortex-m-rtic will stem from this tracking issue.

@tmplt
Copy link
Member Author

tmplt commented Dec 12, 2021

Related to, and depends on rtic-rs/rfcs#51 closing.

@tmplt tmplt changed the title Replace cortex-m-rtic-trace with probe-rs Deprecate cortex-m-rtic-trace Dec 12, 2021
@tmplt tmplt pinned this issue Dec 12, 2021
@tmplt
Copy link
Member Author

tmplt commented Dec 14, 2021

Depends on probe-rs/probe-rs#727.

@tmplt tmplt unpinned this issue Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream This issue is an upstream issue
Projects
None yet
Development

No branches or pull requests

1 participant