Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max field to gdf returned from get_metrics #14

Closed
kvanwerkhoven opened this issue Apr 20, 2023 · 3 comments · Fixed by #18
Closed

Add max field to gdf returned from get_metrics #14

kvanwerkhoven opened this issue Apr 20, 2023 · 3 comments · Fixed by #18
Assignees

Comments

@kvanwerkhoven
Copy link
Member

For post event dashboard 2, I need the maximum value of primary and secondary data for all value_times included in the query:
primary_max:
secondary_max:

I also need the sum of all values, but can calculate from the average. If for any reason the sum would NOT reliably equal the average x count, than also include primary_sum and secondary_sum

@kvanwerkhoven
Copy link
Member Author

Reminder to also add 'measurement_units' to all query outputs

@mgdenno
Copy link
Contributor

mgdenno commented Apr 24, 2023

Reminder to also add 'measurement_units' to all query outputs

@kvanwerkhoven in the short term any field you add to group by will be added to output. This is all we will do in the query (at least the metric ones) because you can't add a field that you don't group_by.

@kvanwerkhoven
Copy link
Member Author

Ah, OK. I thought that would cause it to group all the locations as one 'pool' for metrics calcs since measurement_units are the same for all locations

@mgdenno mgdenno linked a pull request Apr 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants