wrong coefficients in scatter glare correction example

[PHU-medPhoton]

Hi Simon.

I just saw that in your scatter glare corretion example "rtkscatterglarecorrection.cxx" there are two coefficients configured (lines 78 and 79). I guess you wanted to configure the coefficients as described by Poludniowski but the b3 coefficient is wrong (106.244f instead of 10.6244f). This produces huge artefacts and therfore could insecure other users.

Best,
Philipp Huber
medPhoton

[sbrousmiche]

Hi Philipp, Thanks for your remark. We are actually not using the same units as in the reference paper for b3. I agree this should be fixed for clarity. Nevertheless, these are only default values. As the parameters are system-dependent, I suggest we simply remove them no to confuse anyone. Best Regards Sébastien

…

On 27 April 2017 at 10:25, PHU-medPhoton ***@***.***> wrote: Hi Simon. I just saw that in your scatter glare corretion example "rtkscatterglarecorrection.cxx" there are two coefficients configured (lines 78 and 79). I guess you wanted to configure the coefficients as described by Poludniowski but the b3 coefficient is wrong (106.244f instead of 10.6244f). This produces huge artefacts and therfore could insecure other users. Best, Philipp Huber medPhoton — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/SimonRit/RTK/issues/101>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAxKRINskoyGnXmZeFjGwSZNB2yqjl_Wks5r0FEBgaJpZM4NJ5LY> .

[SimonRit]

Hi,
Thanks for your answer Sébastien (it's his filter, not mine!). A better solution would therefore to set them to irrelevant defaults (e.g., itk::NumericTraits::max()) and issue an error if they are not set prior to their use?
Simon

[SimonRit]

Fixed with a87ae69