Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of resources after implicit read #54

Closed
pyhys opened this issue Apr 20, 2020 · 0 comments · Fixed by #55
Closed

Out of resources after implicit read #54

pyhys opened this issue Apr 20, 2020 · 0 comments · Fixed by #55
Labels
bug Something isn't working

Comments

@pyhys
Copy link
Collaborator

pyhys commented Apr 20, 2020 •
edited
Loading

With the PLC in stopped mode, it is possible to do modifications of IP address and station name of the IO-device. This is done via DCP, but the controller is first doing an implicit read to find out details on the IO-device.

A new session is allocated for the implicit reads, but is never closed down. After a while there will be "out of resources"
pyhys pushed a commit to pyhys/p-net that referenced this issue Apr 20, 2020
Release session after PING and implicit read
d7317f7 
When doing a remote change of IP-address or name, a session is
created. Close the session immediately after an implicit read,
as there is no info wheter the session ever will be used again.

There might also be incoming RPC ping requests when changing
the IP-address. Handle those, and close the session.

Improve logging and documentation.

Also the Linux script for changing the IP address etc should be
able to handle invalid (not set) default gatway.

Closes rtlabs-com#54
@pyhys pyhys mentioned this issue Apr 20, 2020
Merged
@pyhys pyhys added the bug Something isn't working label Apr 20, 2020
pyhys pushed a commit to pyhys/p-net that referenced this issue Apr 22, 2020
Release session after PING and implicit read
0dd568c 
When doing a remote change of IP-address or name, an implicit
read is first done by the IO-controller to read out info.
A session is created for this.
Close the session immediately after an implicit read,
as there is no info whether the session ever will be used again.

There might also be incoming RPC ping requests when changing
the IP-address. Handle those, and close the session.

Improve logging and documentation.

Also the Linux script for changing the IP address etc should be
able to handle invalid (not set) default gatway.

Closes rtlabs-com#54
pyhys pushed a commit to pyhys/p-net that referenced this issue Apr 22, 2020
Release session after PING and implicit read
ac06d3b 
When doing a remote change of IP-address or name, an implicit
read is first done by the IO-controller to read out info.
A session is created for this.
Close the session immediately after an implicit read,
as there is no info whether the session ever will be used again.

There might also be incoming RPC ping requests when changing
the IP-address. Implement ping reponse.

Improve logging and documentation.

Also the Linux script for changing the IP address etc should be
able to handle invalid (not set) default gatway.

Closes rtlabs-com#54
pyhys pushed a commit to pyhys/p-net that referenced this issue Apr 22, 2020
Release session after implicit read, and implement ping
56eec83 
When doing a remote change of IP-address or name, an implicit
read is first done by the IO-controller to read out info.
A session is created for this.
Close the session immediately after an implicit read,
as there is no info whether the session ever will be used again.

There might also be incoming RPC ping requests when changing
the IP-address. Implement ping reponse.

Improve logging and documentation.

Also the Linux script for changing the IP address etc should be
able to handle invalid (not set) default gatway.

Closes rtlabs-com#54
pyhys pushed a commit to pyhys/p-net that referenced this issue Apr 22, 2020
Release session after implicit read, and implement ping
2414142 
When doing a remote change of IP-address or name, an implicit
read is first done by the IO-controller to read out info.
A session is created for this.
Close the session immediately after an implicit read,
as there is no info whether the session ever will be used again.

There might also be incoming RPC ping requests when changing
the IP-address. Implement ping reponse, and close the session if
the ping is received on a new session.

Improve logging and documentation.

Also the Linux script for changing the IP address etc should be
able to handle invalid (not set) default gatway.

Closes rtlabs-com#54
hefloryd pushed a commit that referenced this issue Apr 22, 2020
@hefloryd
Release session after implicit read, and implement ping
25bd274 
When doing a remote change of IP-address or name, an implicit
read is first done by the IO-controller to read out info.
A session is created for this.
Close the session immediately after an implicit read,
as there is no info whether the session ever will be used again.

There might also be incoming RPC ping requests when changing
the IP-address. Implement ping reponse, and close the session if
the ping is received on a new session.

Improve logging and documentation.

Also the Linux script for changing the IP address etc should be
able to handle invalid (not set) default gatway.

Closes #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release session after implicit read, and implement ping pyhys/p-net
1 participant
@pyhys