forked from roodi/roodi
-
Notifications
You must be signed in to change notification settings - Fork 0
/
empty_rescue_body_check_spec.rb
114 lines (104 loc) · 2.56 KB
/
empty_rescue_body_check_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
describe Roodi::Checks::EmptyRescueBodyCheck do
before(:each) do
@roodi = Roodi::Core::RubyParserRunner.new(Roodi::Checks::EmptyRescueBodyCheck.new)
end
it "should accept a rescue body with content and no parameter" do
content = <<-END
begin
call_method
rescue
puts "Recover from the call"
end
END
@roodi.check_content(content)
@roodi.errors.should be_empty
end
it "should accept a rescue body with a return" do
content = <<-END
begin
call_method
rescue
return true
end
END
@roodi.check_content(content)
@roodi.errors.should be_empty
end
it "should accept a method call that Ruby won't tell apart from a variable (a vcall)" do
content = <<-END
begin
call_method
rescue
show_error
end
END
@roodi.check_content(content)
@roodi.errors.should be_empty
end
it "should accept a rescue body with content and a parameter" do
content = <<-END
begin
call_method
rescue Exception => e
puts "Recover from the call"
end
END
@roodi.check_content(content)
@roodi.errors.should be_empty
end
it "should accept a rescue body with an assignment" do
content = <<-END
begin
call_method
rescue Exception => e
my_var = 1
end
END
@roodi.check_content(content)
@roodi.errors.should be_empty
end
it "should accept a rescue body with an attribute assignment" do
content = <<-END
begin
call_method
rescue Exception => e
self.var = 1
end
END
@roodi.check_content(content)
@roodi.errors.should be_empty
end
it "should reject an empty rescue block with no parameter" do
content = <<-END
begin
call_method
rescue
end
END
@roodi.check_content(content)
errors = @roodi.errors
errors.should_not be_empty
errors[0].to_s.should match(/dummy-file.rb:[3-4] - Rescue block should not be empty./)
end
it "should accept a rescue block with an explicit nil" do
content = <<-END
call_method rescue nil
END
@roodi.check_content(content)
errors = @roodi.errors
errors.should be_empty
end
it "should reject an empty rescue block with a parameter" do
content = <<-END
begin
call_method
rescue Exception => e
end
END
@roodi.check_content(content)
errors = @roodi.errors
errors.should_not be_empty
errors[0].to_s.should match(/dummy-file.rb:[3-4] - Rescue block should not be empty./)
end
end