Handle blank segments in Cache-Control header.

rtomayko · Dec 22, 2010 · 43c25a0 · 43c25a0
1 parent 428ac19
commit 43c25a0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/rack/cache/cachecontrol.rb b/lib/rack/cache/cachecontrol.rb
@@ -183,6 +183,7 @@ def to_s
       def parse(value)
         return  if value.nil? || value.empty?
         value.delete(' ').split(',').inject(self) do |hash,part|
+          next if part.empty?
           name, value = part.split('=', 2)
           hash[name.downcase] = (value || true) unless name.empty?
           hash

diff --git a/test/cachecontrol_test.rb b/test/cachecontrol_test.rb
@@ -49,6 +49,12 @@
     cache_control['max-age'].should.equal '600'
   end
 
+  it 'strips blank segments' do
+    cache_control = Rack::Cache::CacheControl.new('max-age=600,,max-stale=300')
+    cache_control['max-age'].should.equal '600'
+    cache_control['max-stale'].should.equal '300'
+  end
+
   it 'removes all directives with #clear' do
     cache_control = Rack::Cache::CacheControl.new('max-age=600, must-revalidate')
     cache_control.clear