Rack 2.x compat #61
Merged
Rack 2.x compat #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rack uses autoload, so those requires aren't needed. And `rack/commonlogger` was renamed to `rack/common_logger` in Rack 2.x, causing Shotgun to be unusable under Rack >= 2.0
|
I just stumbled upon the exact same issue. So effectively this PR will also close #62 |
|
+1. I ran into the same Rack 2.x issue. |
|
I can confirm this PR is working nicely. I've incorporated it into a (hopefully short-lived) fork of shotgun, just so there's an easy way for people to continue to install a development server that works with the latest Rack releases: https://rubygems.org/gems/notgun Shotgun maintainers: if you need help cutting a new release, I'd be happy to put my hand up and take care of it for you 🙋. Shotgun's important to me and dry-rb as the preferred development server for dry-web-roda and I'd love to see the project continue to work 😄 |
|
Released as 0.9.2. Thank you and apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rack/commonloggerwas renamed torack/common_loggerin Rack 2.x, causing Shotgun to be unusable under Rack >= 2.0But since Rack uses autoload, those requires aren't needed anyways.