Skip to content

Commit

Permalink
display deprecation warning if Tilt::CompileSite is included
Browse files Browse the repository at this point in the history
  • Loading branch information
@rkh
rkh committed Dec 23, 2010
1 parent d078513 commit f1f7aac
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/tilt.rb
View file
Expand Up @@ -43,6 +43,9 @@ def self.[](file)

# Deprecated module.
module CompileSite
def self.append_features(mod, *)
warn "WARNING: Tilt::CompileSite is deprecated and will be removed in Tilt 2.0 (#{caller.first})."
end
end

# Base class for template implementations. Subclasses must implement
Expand Down

5 comments on commit f1f7aac

@josh
Copy link
Contributor

@josh josh commented on f1f7aac Dec 24, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of an annoyance than anything else. It's not like the module is harmful.

Most people don't use tilt directly but via another framework. They're going to be seeing this and not be able to do anything about it.

I'd rather of just removed it so a defined? check would still work.

@rkh
Copy link
Collaborator Author

@rkh rkh commented on f1f7aac Dec 24, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it would mean Tilt version would have to be increased to 2.0, if Tilt is following semver.

@rkh
Copy link
Collaborator Author

@rkh rkh commented on f1f7aac Dec 24, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I see your point.

@josh
Copy link
Contributor

@josh josh commented on f1f7aac Dec 24, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it doesnt break anything, you could still consider it a voilation of semver since it changes the behavior of the module. The current release of Sinatra is effectively incompatible with tilt 1.2.

The best thing todo is to remove the warning and release Tilt 1.2.1

@rtomayko
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I'll do that.

Please sign in to comment.