Removed changing constant lookup scope in compiled templates. #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It singificantly simplifies code and removes extra lines with
wrong source locations from backtrace.
Without this commit backtrace is:
After:
It's especially confusing when used with real files, because locations point to other source.
This can also be avoided by using
method_source.lines.map(&:strip).join('; ')
to concat lines. But I think it's not a big problem to useself.class::CONST
instead of justCOST
even explicit constant lookup.