Do not modify BasicObject during template compilation on ruby 2.0+ #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in ruby 2.0, you can unbind methods from modules and bind them to any object, and then call them. There is no reason to modify the BasicObject class in this case. This fixes tilt's template compilation on ruby 2.0+ when BasicObject is frozen.
|
How come I never knew about this trick? |
|
Will this be released soon? |
|
I just released Tilt 2.0.7 now |
|
Thanks! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in ruby 2.0, you can unbind methods from modules and
bind them to any object, and then call them. There is no reason
to modify the BasicObject class in this case.
This fixes tilt's template compilation on ruby 2.0+ when BasicObject
is frozen.