Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mustache support #51

Closed
wants to merge 1 commit into from
Closed

Mustache support #51

wants to merge 1 commit into from

Conversation

becojo
Copy link

@becojo becojo commented Dec 23, 2010

No description provided.

@rkh
Copy link
Collaborator

rkh commented Dec 24, 2010

For discussion on that topic, see related issue.

@judofyr
Copy link
Collaborator

judofyr commented Jan 17, 2011

Mustache isn't a regular template engine in the way that it requires two parts: a template and an implementation (in Ruby). Chris (of Mustache) closed the equivalent issue at Mustache's issue tracker because a Tilt implementation (at least the one provided here) wouldn't be able to take advantage of Mustache's core concept.

This patch also uses an interpreted mode even when Mustache is actually compiled behind the scenes.

In the future I'd also like to see that template engines implement they're own Tilt-support (like Slim) instead of having one big tilt.rb.

I'm closing this for now, but feel free to open it if you can:

  1. Show how you can effectively use Mustache with Tilt (like you do in Sinatra)
  2. Provide a patch which uses Mustache's compiler (actually, I can write this if you can describe the semantics)
  3. Convince us that this belongs in Tilt's and not Mustache's codebase

@judofyr
Copy link
Collaborator

judofyr commented Jan 17, 2011

Actually, I think it's best to keep the issue open so it still appears on the front page in the issue tracker. And it's still an issue (which I'd love to see resolved), even if the current patch isn't good enough. I'm rather tagging it as "feedback".

@rtomayko
Copy link
Owner

Agreed on all parts.

@josh
Copy link
Contributor

josh commented Feb 21, 2011

I'm in favor of including it. Evaluating mustache templates with #render({ :simple => "hash" }) is pretty useful IMO

@judofyr
Copy link
Collaborator

judofyr commented Apr 12, 2011

I see your point @josh, but I still believe this belongs into Mustache's codebase.

@josh
Copy link
Contributor

josh commented Apr 12, 2011

Seems good. Wana close this ticket?

@judofyr
Copy link
Collaborator

judofyr commented Apr 12, 2011

Wo-hoo! I love closing tickets!

@judofyr judofyr closed this Apr 12, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants