fixed derived class unloading for plugins #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following use case: 1. A plugin: "A" creates a new class derived from some base class in a dynamic library: "B". 2. An applications loads now B implicit (its always in memory) and loads "A" via RTTR 3. When "A" gets unloaded the derived class is still connected to the library "B" So when I retrieve all derived classes from a library of B, I still get the derived type as returned library. This commit will fix this.
The base_types has to be provided as argument explicitely and cannot be retrieve via the type_data itself, because the `class_data` which holds the base_types information cannot be retrieve via the function `get_class_data` anymore because the containing std::unique_ptr is already destroyed.
…ger, therefore we have to can use the class_data from the type via the getter directly. In other case the type_data can be deregistered when the class_data is destroyed, then we use the this pointer.
* avoided creation of class_data for every type (pointer types)
No more unique_ptr, it holds the data now directly. So we can avoid handling the creation and destroying logic. At the moment the class data was created always even for simple types like "int". However, this not needed memory is not sooo much, compared to the simplified code.
|
fixes #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following use case:
So when I retrieve all derived classes from a library of B, I still get the derived type as returned library.
This commit will fix this.