Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue3 port #93

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

vue3 port #93

wants to merge 2 commits into from

Conversation

kwesterfeld2
Copy link

  • use composition api vs. vue-class-component/vue-property-decorator, via <script setup> means of component dev
  • fix v-model breaking changes for vue 3
  • update demo app accordingly
  • implement event bus via mitt
  • build with vite; remove vue cli
  • update dep for vuedraggable; change API interaction with vuedraggable to deal with proxied children, due to requirement for itemKey per draggable.
  • update miscellaneous deps for building with vite, linting, etc
  • update tests to use vitest

 - use composition api vs. vue-class-component/vue-property-decorator,
   via <script setup> means of component dev
 - fix v-model breaking changes for vue 3
 - update demo app accordingly
 - implement event bus via mitt
 - build with vite; remove vue cli
 - update dep for vuedraggable; change API interaction with vuedraggable
   to deal with proxied children, due to requirement for itemKey per
   draggable.
 - update miscellaneous deps for building with vite, linting, etc
 - update tests to use vitest
@kwesterfeld2
Copy link
Author

@rtucek I realized my branch did commit build files. I did this so my app could consume them.

Do you want a PR without build files?

BTW, very impressive work with the complete test coverage. I was able to get most of the port done in a day but struggled with some test failures for about a week and it turns out there were some very subtle port issues for vue 3 and it's proxy handling of components.

@rtucek
Copy link
Owner

rtucek commented Nov 24, 2022

@kwesterfeld2 woha, this is amazing.

I'll check when I'm home again as I'm traveling right now for 1 week.

No, you don't need to provide build files, as I'm creating them anyway prior tagging a release.

Also thank you for the credit on testing :)
I had to add it, because I broke it way to often by myself 😆

Do you think we'd also have to adjust the docs?
I'm sort of thinking to to split the docs for Vue 2 and Vue 3 and duplicate + port the Codesandbox samples.

@kwesterfeld2
Copy link
Author

I'm not sure how to proceed with releasing the component for vue 3. What I see some developers do is bump the major version and declare that "if you want vue 2 support use version prior." Something like that.

Also, I see that lint checks are failing, but that's likely because of the way in which the entire stack is rebuilt using new versions of everything. Also, I'm not sure I'm good enough at Typescript to adjust code to fix some of the warnings it finds. I've been doing JS a very long time but TS is something I don't dabble much in.

Let me know if you need a new PR with anything adjusted.

@Davidbadasyan
Copy link

Davidbadasyan commented Aug 3, 2023

@kwesterfeld2 hello, I have a small question (about the vue3), how can be talked about?

@kwesterfeld2
Copy link
Author

kwesterfeld2 commented Aug 3, 2023 via email

@Davidbadasyan
Copy link

Davidbadasyan commented Aug 3, 2023

I have copied your changes and made a build to use this vue query builder but it is giving me some strange error did you use it was it fine?
cannot read properties of undefined (reading '_init') vue
image
image

image
image

@kwesterfeld2
Copy link
Author

kwesterfeld2 commented Aug 3, 2023 via email

@Davidbadasyan
Copy link

will this be fixed with your PR?

@Davidbadasyan
Copy link

did you use the vue-query-builder that you made for vue 3 and how you implemented it in your project or do you still wait to merge pr and after do it?

@Davidbadasyan
Copy link

how can I send a video screen?

@Davidbadasyan
Copy link

are you available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants