Fix issue #2, reducing the oauth scope permissions required from user #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `public_repo` requirement is dropped, with users now only required to give the `user:email` scope so we can get their email address. https://developer.github.com/v3/oauth/#scopes Note that existing users will get a slightly alarming-looking notification from GitHub to tell them that the required permissions have been reduced:  The PR comment generated when a user sends mail to the list is now made by the @submitgit account. Conditional response caching with OkHttp is now also enabled so that there's less risk of running out of GitHub API quota - given that now we don't take advantage of the user's quota. http://thread.gmane.org/gmane.comp.version-control.git/269699/focus=269733
rtyley
added a commit
that referenced
this pull request
May 29, 2015
Fix issue #2, reducing the oauth scope permissions required from user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
public_reporequirement is dropped, with users now only required to give theuser:emailscope so we can get their email address.Note that existing users will get a slightly alarming-looking notification from GitHub to tell them that the required permissions have been reduced:
The PR comment generated when a user sends mail to the list is now made by the @submitgit account.
Conditional response caching with OkHttp is now also enabled so that there's less risk of running out of GitHub API quota - given that now we don't take advantage of the user's quota.
cc @gitster for #2
http://thread.gmane.org/gmane.comp.version-control.git/269699/focus=269733