Skip to content

Commit

Permalink
align with golang 1.8 and latest gokit context
Browse files Browse the repository at this point in the history
  • Loading branch information
ru-rocker committed Mar 10, 2017
1 parent d1bb1c7 commit 46559b5
Show file tree
Hide file tree
Showing 10 changed files with 23 additions and 17 deletions.
2 changes: 1 addition & 1 deletion lorem-grpc/endpoints.go
Expand Up @@ -3,7 +3,7 @@ package lorem_grpc
import (
"github.com/go-kit/kit/endpoint"
"errors"
"golang.org/x/net/context"
"context"
)


Expand Down
2 changes: 1 addition & 1 deletion lorem-grpc/model.go
Expand Up @@ -2,7 +2,7 @@ package lorem_grpc

import (
"github.com/ru-rocker/gokit-playground/lorem-grpc/pb"
"golang.org/x/net/context"
"context"
)

//Encode and Decode Lorem Request
Expand Down
2 changes: 1 addition & 1 deletion lorem-grpc/service.go
Expand Up @@ -4,7 +4,7 @@ import (
gl "github.com/drhodes/golorem"
"strings"
"errors"
"golang.org/x/net/context"
"context"
)

var (
Expand Down
3 changes: 1 addition & 2 deletions lorem-grpc/transport.go
Expand Up @@ -20,10 +20,9 @@ func (s *grpcServer) Lorem(ctx context.Context, r *pb.LoremRequest) (*pb.LoremRe
}

// create new grpc server
func NewGRPCServer(ctx context.Context, endpoint Endpoints) pb.LoremServer {
func NewGRPCServer(_ context.Context, endpoint Endpoints) pb.LoremServer {
return &grpcServer{
lorem: grpctransport.NewServer(
ctx,
endpoint.LoremEndpoint,
DecodeGRPCLoremRequest,
EncodeGRPCLoremResponse,
Expand Down
3 changes: 2 additions & 1 deletion lorem-logging/endpoints.go
Expand Up @@ -4,7 +4,8 @@ import (
"github.com/go-kit/kit/endpoint"
"strings"
"errors"
"golang.org/x/net/context"
"context"
//"golang.org/x/net/context"
)

var (
Expand Down
13 changes: 10 additions & 3 deletions lorem-logging/lorem-logging.d/main.go
Expand Up @@ -15,12 +15,19 @@ func main() {
ctx := context.Background()
errChan := make(chan error)

logfile, err := os.OpenFile("./golorem.log", os.O_RDWR | os.O_CREATE | os.O_APPEND, 0666)
if err != nil {
panic(err)
}
defer logfile.Close()

// Logging domain.
var logger log.Logger
{
logger = log.NewLogfmtLogger(os.Stderr)
logger = log.NewContext(logger).With("ts", log.DefaultTimestampUTC)
logger = log.NewContext(logger).With("caller", log.DefaultCaller)
w := log.NewSyncWriter(logfile)
logger = log.NewLogfmtLogger(w)
logger = log.With(logger, "ts", log.DefaultTimestampUTC)
logger = log.With(logger, "caller", log.DefaultCaller)
}

var svc lorem_logging.Service
Expand Down
6 changes: 3 additions & 3 deletions lorem-logging/transport.go
Expand Up @@ -10,7 +10,8 @@ import (
httptransport "github.com/go-kit/kit/transport/http"
"encoding/json"
"strconv"
"golang.org/x/net/context"
//"golang.org/x/net/context"
"context"
)

var (
Expand All @@ -19,7 +20,7 @@ var (
)

// Make Http Handler
func MakeHttpHandler(ctx context.Context, endpoint Endpoints, logger log.Logger) http.Handler {
func MakeHttpHandler(_ context.Context, endpoint Endpoints, logger log.Logger) http.Handler {
r := mux.NewRouter()
options := []httptransport.ServerOption{
httptransport.ServerErrorLogger(logger),
Expand All @@ -28,7 +29,6 @@ func MakeHttpHandler(ctx context.Context, endpoint Endpoints, logger log.Logger)

//POST /lorem/{type}/{min}/{max}
r.Methods("POST").Path("/lorem/{type}/{min}/{max}").Handler(httptransport.NewServer(
ctx,
endpoint.LoremEndpoint,
decodeLoremRequest,
encodeResponse,
Expand Down
2 changes: 1 addition & 1 deletion lorem/endpoints.go
Expand Up @@ -4,7 +4,7 @@ import (
"github.com/go-kit/kit/endpoint"
"strings"
"errors"
"golang.org/x/net/context"
"context"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions lorem/lorem.d/main.go
Expand Up @@ -25,8 +25,8 @@ func main() {
var logger log.Logger
{
logger = log.NewLogfmtLogger(os.Stderr)
logger = log.NewContext(logger).With("ts", log.DefaultTimestampUTC)
logger = log.NewContext(logger).With("caller", log.DefaultCaller)
logger = log.With(logger, "ts", log.DefaultTimestampUTC)
logger = log.With(logger, "caller", log.DefaultCaller)
}

r := lorem.MakeHttpHandler(ctx, endpoint, logger)
Expand Down
3 changes: 1 addition & 2 deletions lorem/transport.go
Expand Up @@ -10,7 +10,7 @@ import (
httptransport "github.com/go-kit/kit/transport/http"
"encoding/json"
"strconv"
"golang.org/x/net/context"
"context"
)

var (
Expand All @@ -28,7 +28,6 @@ func MakeHttpHandler(ctx context.Context, endpoint Endpoints, logger log.Logger)

//POST /lorem/{type}/{min}/{max}
r.Methods("POST").Path("/lorem/{type}/{min}/{max}").Handler(httptransport.NewServer(
ctx,
endpoint.LoremEndpoint,
decodeLoremRequest,
encodeResponse,
Expand Down

0 comments on commit 46559b5

Please sign in to comment.