Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target fps boo boo #429

Closed
mrElnekave opened this issue Dec 4, 2022 · 1 comment · Fixed by #432
Closed

target fps boo boo #429

mrElnekave opened this issue Dec 4, 2022 · 1 comment · Fixed by #432
Labels
bug Something isn't working medium priority This is a medium priority issue
Milestone
v1.0.0

Comments

@mrElnekave
Copy link
Collaborator

BUG:

rb.init(res=(500, 500), maximize=True, target_fps=60)

not actually capping.
@mrElnekave mrElnekave added bug Something isn't working medium priority This is a medium priority issue labels Dec 4, 2022
@mrElnekave mrElnekave added this to the v1.0.0 milestone Dec 4, 2022
@tsedan
Copy link
Member

tsedan commented Dec 4, 2022

I think this is due to floating point error since our delta_time and normal_deltas are really tiny
The solution is to untranslate some of our backend stuff back to milliseconds

@tinmarr tinmarr mentioned this issue Dec 6, 2022
Merged
4 tasks
@tinmarr tinmarr linked a pull request Dec 6, 2022 that will close this issue
fix target_fps #432
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working medium priority This is a medium priority issue
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix target_fps rubatopy/rubato
2 participants
@tsedan @mrElnekave