Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Inspections return in random order, regardless of Grouping selection #1618

Closed
ThunderFrame opened this issue May 29, 2016 · 3 comments
Closed
Assignees
Labels
enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-inspections user-interface This issue explicitly relates to the visible interface of Rubberduck.
Milestone

Comments

@ThunderFrame
Copy link
Member

In these screenshots, my Code Inspections Window has Grouping.. By Inspection Type checked.

As per #1617 I need to refresh using the toolbar Refresh button, but these are the Code Inspection results after subsequent presses....

Imgur

Imgur

Imgur

Imgur

Imgur

@Hosch250
Copy link
Member

What is the problem here? That it isn't grouped by inspection but by inspection type, that the order of the displayed groupings is sporadic, or that the order of the inspections in the groupings is sporadic?

@retailcoder
Copy link
Member

@Hosch250 the results are being displayed in whatever order the inspections happen to be running; the UI intends to be sorting them - even just sorting by inspection would stabilize the sorting. I thought this was addressed loooooong ago...

@Hosch250 Hosch250 added enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. user-interface This issue explicitly relates to the visible interface of Rubberduck. feature-inspections labels Jun 3, 2016
@Hosch250 Hosch250 added this to the Version 2.0 milestone Jun 3, 2016
@Hosch250
Copy link
Member

Hosch250 commented Jun 7, 2016

<CollectionViewSource x:Key="ResultsByInspectionType" Source="{Binding Results}">
    <CollectionViewSource.SortDescriptions>
        <componentModel:SortDescription PropertyName="Inspection.InspectionType"/>
        <componentModel:SortDescription PropertyName="Inspection.Name"/>
        <componentModel:SortDescription PropertyName="QualifiedSelection.QualifiedName.Name"/>
        <componentModel:SortDescription PropertyName="QualifiedSelection.Selection.StartLine"/>
        <componentModel:SortDescription PropertyName="QualifiedSelection.Selection.StartColumn"/>
    </CollectionViewSource.SortDescriptions>
    <CollectionViewSource.GroupDescriptions>
        <PropertyGroupDescription PropertyName="Inspection" Converter="{StaticResource InspectionTypeConverter}" />
    </CollectionViewSource.GroupDescriptions>
</CollectionViewSource>

<CollectionViewSource x:Key="ResultsByModule" Source="{Binding Results}">
    <CollectionViewSource.SortDescriptions>
        <componentModel:SortDescription PropertyName="QualifiedSelection.QualifiedName.Name"/>
        <componentModel:SortDescription PropertyName="Inspection.Name"/>
        <componentModel:SortDescription PropertyName="QualifiedSelection.Selection.StartLine"/>
        <componentModel:SortDescription PropertyName="QualifiedSelection.Selection.StartColumn"/>
    </CollectionViewSource.SortDescriptions>
    <CollectionViewSource.GroupDescriptions>
        <PropertyGroupDescription PropertyName="QualifiedSelection.QualifiedName" />
    </CollectionViewSource.GroupDescriptions>
</CollectionViewSource>

Looks like it is supposed to be sorting. Adding IsLiveSortingRequested="True" makes it much more reliable than it is now, but not completely.

@Hosch250 Hosch250 self-assigned this Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-inspections user-interface This issue explicitly relates to the visible interface of Rubberduck.
Projects
None yet
Development

No branches or pull requests

3 participants